[dependencies] update 3rd party dependencies #407
Conversation
apalala
added
enhancement
dependencies
.github/workflows/python-app.yml
Outdated
| # stop the build if there are Python syntax errors or undefined names | ||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics |
There was a problem hiding this comment.
Why not use tox instead of using flake8 directly, and keep this within the tox configuration so that running tox -e flake8 has the same effect, and users can run that locally?
There was a problem hiding this comment.
Github Actions were an experiment. We don't need them now, so I'll remove them.
|
Tip: add |
| 'tqdm==4.55.1', | ||
| 'tqdm', |
There was a problem hiding this comment.
We should probably keep some limit, assuming we do not support just any version.
tests/requirements.txt
Outdated
| virtualenv==20.7.2 | ||
| # via pipenv | ||
| virtualenv-clone==0.5.7 | ||
| # via pipenv | ||
|
|
||
| # The following packages are considered to be unsafe in a requirements file: | ||
| # pip |
There was a problem hiding this comment.
It probably makes sense to remove this file in favor of tox.ini.
There was a problem hiding this comment.
We discussed this on Slack.
requirements.txt and requirements-test.txt serve to document the versions of the libraries that passed the tests when the branch was merged.
| @@ -505,6 +505,7 @@ def get_project_dir(): | |||
| os.path.join(basepath, 'a', 'b')) | |||
|
|
|||
|
|
|||
| @unittest.skip('broken by changes in `click.invoke(input=)`') | |||
There was a problem hiding this comment.
Then we should either address this in code or limit the upper version of click to a version we support in setup.py.
There was a problem hiding this comment.
No. This test is complicated yet unimportant, so not enough reason to downgrade click.
Also, there should be only minor changes on this release.
I'll leave this comment open to remind us to search or post an issue against click.
…' into update_dependencies
Remove pins to very old versions that produce conflicts with other tools used alongside Scrapy (#404).
Remove
requirements.inand rely onsetup.py.install_requires.Remove
pipfrom dependencies as mentioning it is deemed unsafe.Upgrade all libraries through
pip-compile --upgrade.Hopefully solve security warnings reported by dependabot.
This PR drops support for Python 2.7, 3.5, and 3.6.
fixes #406
fixes #412