Raising exception on utils#find_api_key #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josericardo
force-pushed
the
raise-no-credentials-exception
branch
from
ff7a1a8 to
95b2ab3
Compare
|
Why do we need the custom class?. Why not just raise ClickException with the error message? |
|
As a rule, I try not to raise generic exceptions. I think the code gets a little more expressive (even if no one is handling it, yet). Should I remove it? |
|
I don't think there's a need for a custom exception in this case, and I prefer to keep the code simpler without them. |
|
The first need for a custom exception class would come when we need to raise the same exception from multiple places, and in that case the exception message ("Use 'shub login' or ...") should probably be in the class definition, not passed at exception creation. |
josericardo
force-pushed
the
raise-no-credentials-exception
branch
from
95b2ab3 to
fd6113c
Compare
Raising a ClickException, which is handled nicely by click, displaying the error msg and returning an exit code != 0.
josericardo
force-pushed
the
raise-no-credentials-exception
branch
from
fd6113c to
36e8a9f
Compare
josericardo
changed the title
|
You're right. Updated :) |
pablohoffman
added a commit
that referenced
this pull request
Jun 22, 2015
Raising exception on utils#find_api_key
This was referenced Jun 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoCredentialsException is a ClickException, which is handled nicely by
click, displaying the error msg and returning an exit code != 0.
Fixes #32 and #34