Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit value does not reflect an authentication failure #31

Closed
rmax opened this issue Jun 18, 2015 · 2 comments
Closed

Exit value does not reflect an authentication failure #31

rmax opened this issue Jun 18, 2015 · 2 comments

Comments

@rmax
Copy link
Contributor

rmax commented Jun 18, 2015

I think if any API call fails (i.e. auth error) then the command should exit with a non-zero status. The example below shows how shub exit with zero status regardless of the auth failure.

$ shub deploy-egg 1462X       
Building egg in: /home/rolando/foo
zip_safe flag not set; analyzing archive contents...
Deploying dependency to Scrapy Cloud project "1462X"
Deploy failed (403):
{"status": "error", "message": "Authentication failed"}
Deployed eggs list at: https://dash.scrapinghub.com/p/1462X/eggs
$ echo $?
0
@eliasdorneles
Copy link
Contributor

+1 that error should be handled and give the user a proper actionable message.

@josericardo
Copy link
Contributor

This was fixed by #37 and #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants