Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Geeklist format #9

Open
Crickmcd opened this issue May 5, 2022 · 5 comments
Open

New Geeklist format #9

Crickmcd opened this issue May 5, 2022 · 5 comments

Comments

@Crickmcd
Copy link

Crickmcd commented May 5, 2022

The BGG geeklist format appears to have changed today and BGG++ has stopped working. :(

@scraimer
Copy link
Owner

scraimer commented May 8, 2022

Thanks for reporting it. I had a look at the new site, and my rusty Javascript/HTML skills are not up to the the task of fixing the extension (at least, not in the time I have available).

Thank you for using the extension, but I think this is the end of the road for it.

@rafal-watorski
Copy link
Contributor

rafal-watorski commented May 8, 2022 via email

@nkostas
Copy link

nkostas commented Jun 2, 2022

May this piece of code helps.
https://boardgamegeek.com/filepage/241250/new-item-bookmarklet

It's Javascript to iterate through new items of a geeklist and works with the new format.

I don't have the skills to modify bgg++

@rafal-watorski
Copy link
Contributor

rafal-watorski commented Jun 2, 2022

@nkostas I already figured out that part, but thanks. The main problem is to figure out the moment when the page should be checked for new items (those with red border). Previously they were checked when the page was "ready", but now even if Document.readyState == 'complete', the items still keep loading (apparently angular is used). I have a few ideas, but it will take me some time to test it.

After this is fixed, the next issues would be:

  • Manifest version 2 is deprecated, and support will be removed in 2023., meaning an update to manifest version 3 would be needed, meaning I would need to check how much needs to be changes to comply with it...
  • Geeklist comments are not expanded after the page loads, which messes counting new items. Red border is around "6 comments", but after clicking on it new comments are now visible, but the counting needs to be done again...

@rafal-watorski
Copy link
Contributor

Unfortunately this is not that easy, there are too many issues and I don't have enough free time to work on this plugin, so unless someone else takes over, it seems it's really the end of the road for the plugin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants