Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend [Scout] to all log messages for Scout #93

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Prepend [Scout] to all log messages for Scout #93

merged 1 commit into from
Oct 10, 2019

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Oct 10, 2019

Fixes #86

@asgrim asgrim added enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement labels Oct 10, 2019
@asgrim asgrim requested a review from cschneid October 10, 2019 10:48
@cschneid
Copy link
Contributor

Remove all the manually added [Scout] prefixes from log points as well? Both in this agent, and also the scout-apm-laravel side.

@asgrim asgrim mentioned this pull request Oct 10, 2019
Closed
@asgrim
Copy link
Collaborator Author

asgrim commented Oct 10, 2019

Remove all the manually added [Scout] prefixes from log points as well? Both in this agent, and also the scout-apm-laravel side.

I checked here, there's none; there are in the Laravel binding, created issue scoutapp/scout-apm-laravel#24 to handle.

@cschneid cschneid merged commit 467ed5f into master Oct 10, 2019
@asgrim asgrim deleted the 86-prepend-scout-tag-to-log-messages branch October 10, 2019 15:10
@asgrim asgrim added this to the 0.3.0 milestone Oct 17, 2019
cschneid pushed a commit that referenced this pull request Dec 3, 2019
Update CoreAgent version to 1.2.6, with several bug fixes:
3982b87 
(from CA's changelog)

[1.2.6] 2019-12-03

Fixed:

* Use SQL derived names in SpanTraces (#97)

[1.2.5] 2019-12-02

Added:

* Autoclose running spans when request finishes (#93)
* Rate Limit AppServerLoad metadata (#94)
* Add `language_version` key to AppServerLoad metadata (#95)

Fixed:

* Prevent errors if AppServerLoad metadata is not set (#92)
@cschneid cschneid mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschneid cschneid Awaiting requested review from cschneid

Assignees

@cschneid cschneid

Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Milestone
0.2.3
Development

Successfully merging this pull request may close these issues.

Prepend [Scout] to all log messages in FilteredLogLevelDecorator
2 participants
@asgrim @cschneid