Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't capture backtraces for Controller and Middleware #94

Closed
cschneid opened this issue Oct 10, 2019 · 0 comments · Fixed by #96
Closed

Don't capture backtraces for Controller and Middleware #94

cschneid opened this issue Oct 10, 2019 · 0 comments · Fixed by #96
Assignees
@asgrim
Labels
enhancement New feature or request

Comments

@cschneid
Copy link
Contributor

Similar feature in python: https://github.com/scoutapp/scout_apm_python/blob/master/src/scout_apm/core/tracked_request.py#L207

We don't want to spend effort capturing backtraces that don't add any value. Controller and Middleware will always be a large stack of internal-to-the-framework frames, and nothing customer actionable.
@asgrim asgrim added the enhancement New feature or request label Oct 17, 2019
@asgrim asgrim mentioned this issue Oct 17, 2019
Merged
@asgrim asgrim self-assigned this Oct 17, 2019
cschneid pushed a commit that referenced this issue Dec 3, 2019
Update CoreAgent version to 1.2.6, with several bug fixes:
3982b87 
(from CA's changelog)

[1.2.6] 2019-12-03

Fixed:

* Use SQL derived names in SpanTraces (#97)

[1.2.5] 2019-12-02

Added:

* Autoclose running spans when request finishes (#93)
* Rate Limit AppServerLoad metadata (#94)
* Add `language_version` key to AppServerLoad metadata (#95)

Fixed:

* Prevent errors if AppServerLoad metadata is not set (#92)
@cschneid cschneid mentioned this issue Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress backtraces for Controller/Middleware/Job spans scoutapp/scout-apm-php
2 participants
@cschneid @asgrim