#82 - configurable scout log level #83
Conversation
| @@ -108,7 +108,7 @@ private function run() : bool | |||
| { | |||
| $this->logger->debug('Core Agent Launch in Progress'); | |||
| try { | |||
| $logLevel = $this->config->get('log_level'); | |||
| $logLevel = $this->config->get('agent_log_level'); | |||
There was a problem hiding this comment.
Note: this is likely a BC break, so I'm happy to take suggestions on "naming" stuff here...
There was a problem hiding this comment.
The python names, and names here are mostly core_agent_KEY as the pattern for config. So why not core_agent_log_level for this.
There was a problem hiding this comment.
OK: I've extracted all config key strings I could find and put them into a single class to keep naming consistent. I then renamed the core agent-related keys in dbbe20d as follows:
log_level=>core_agent_log_levellog_file=>core_agent_log_fileconfig_file=>core_agent_config_filesocket_path=>core_agent_socket_pathdownload_url=>core_agent_download_url
These are all BC breaks of course, but if you're happy with these renames, it does add consistency. I've noted these changes in the CHANGELOG.md.
| @@ -108,7 +108,7 @@ private function run() : bool | |||
| { | |||
| $this->logger->debug('Core Agent Launch in Progress'); | |||
| try { | |||
| $logLevel = $this->config->get('log_level'); | |||
| $logLevel = $this->config->get('agent_log_level'); | |||
There was a problem hiding this comment.
The python names, and names here are mostly core_agent_KEY as the pattern for config. So why not core_agent_log_level for this.
asgrim
force-pushed
the
82-configurable-scout-log-level
branch
from
2d89edb to
dbbe20d
Compare
Fixes #82