Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurable LogLevel specific to Scout Agent #82

Closed
cschneid opened this issue Sep 27, 2019 · 0 comments · Fixed by #83
Closed

Add Configurable LogLevel specific to Scout Agent #82

cschneid opened this issue Sep 27, 2019 · 0 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request

Comments

@cschneid
Copy link
Contributor

The Problem

Currently, we log all scout specific messages via the $logger parameter into the agent. But that can be awkward since you can't easily set the log level distinctly between Scout and the rest of your Application.

Proposed solution

Continue to take a $logger when constructing the agent. Output will be output there in the end.

Add a log_level config that takes the classic "debug", "info", "warn", "error" levels.

Add a ScoutLog class that all internal logging is routed through. It filters any messages noisier than the config that is set, and hands any left over to the provided $logger. If the config isn't set, pass through all messages.

Change all internal logging (in this repo, and also the -laravel repo) to use the new logger.

Document the new logging configuration & how it works in https://github.com/scoutapp/slate_apm_help/blob/master/source/includes/_php.md

@cschneid cschneid added the enhancement New feature or request label Sep 27, 2019
@asgrim asgrim self-assigned this Sep 27, 2019
@asgrim asgrim closed this as completed in #83 Oct 8, 2019
asgrim added a commit that referenced this issue Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants