Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring improvements housekeeping #34

Merged
merged 46 commits into from
Aug 21, 2019
Merged

Refactoring improvements housekeeping #34

merged 46 commits into from
Aug 21, 2019

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Aug 20, 2019

No description provided.

asgrim added 23 commits August 20, 2019 08:30
@asgrim
Removed php-cs-fixer - we will replace with the much stricter doctrin…
3e1858e 
…e/coding-standards
@asgrim
Added doctrine/coding-standard to apply stricter coding standards acr…
6371abb 
…oss code
@asgrim
Apply new coding standards across codebase
fc6297c
@asgrim
Added Psalm to run static analysis on codebase
47ceebf
@asgrim
Fix issues found by static analysis
4ffb5f9
@asgrim
Fixing up unit test execution so it passes again
3a976d7
@asgrim
Updated documentation with new tools and formatting consistency
085069d
@asgrim
Define interface for type coercion and move to separate namespace
d5fe5d4
@asgrim
Move config sources into logical namespace
d10befb
@asgrim
Add missing @Covers annotations and static method usage
f47afb5
@asgrim
Prefer type-safe assertions in test suite
192f0e5
@asgrim
Fixing new CS issues arising from refactor
fc14fa4
@asgrim
Move classes related to CoreAgent into separate namespace and made @i…
3570ffd 
…nternal
@asgrim
Audit classes for @internal and @deprecated markers
c1dea25
@asgrim
Add interface for Connector
5eb2c7b
@asgrim
Use constructor injection for creating an Agent
763a5bb
@asgrim
Deprecate Agent#getRequest()
d878ca0
@asgrim
Eliminated multiple unused classes
2287d37
@asgrim
Move Tag, Span, and Request into namespaces
6e779e4
@asgrim
Replace usage of Uuids with semantic RequestId and SpanId which give …
af83263 
…more contextual meaning
@asgrim
Integration tests should not generate coverage
f81a6ca
@asgrim
Serialize IDs properly
b9e9b19
@asgrim
Propose better way of injecting configuration to Agent - requires a r…
e125940 
…efactor to use immutable config
@asgrim asgrim added the WIP Work in progress - do not merge label Aug 20, 2019
@asgrim asgrim self-assigned this Aug 20, 2019
cschneid
cschneid reviewed Aug 20, 2019
View reviewed changes
src/Agent.php Outdated Show resolved Hide resolved
@asgrim asgrim assigned asgrim and unassigned cschneid Aug 21, 2019
@asgrim asgrim added the WIP Work in progress - do not merge label Aug 21, 2019
@asgrim asgrim changed the title Refactoring improvements housekeeping WIP - Refactoring improvements housekeeping Aug 21, 2019
@asgrim asgrim mentioned this pull request Aug 21, 2019
Closed
@asgrim asgrim removed the WIP Work in progress - do not merge label Aug 21, 2019
@asgrim asgrim assigned cschneid and unassigned asgrim Aug 21, 2019
@asgrim asgrim requested a review from cschneid August 21, 2019 09:49
@asgrim asgrim changed the title WIP - Refactoring improvements housekeeping Refactoring improvements housekeeping Aug 21, 2019
@cschneid cschneid merged commit 7e18912 into master Aug 21, 2019
@asgrim asgrim deleted the refactoring-improvements-housekeeping branch August 21, 2019 15:33
@asgrim asgrim added this to the 0.1.1 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlanderson dlanderson dlanderson left review comments

@cschneid cschneid cschneid left review comments

Assignees

@cschneid cschneid

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@asgrim @cschneid @dlanderson