Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if version is being used correctly in \Scoutapm\CoreAgent\Manifest #35

Closed
asgrim opened this issue Aug 21, 2019 · 2 comments
Closed
Labels
question Further information is requested

Comments

@asgrim
Copy link
Collaborator

asgrim commented Aug 21, 2019

Issue raised from discussion in #34 (comment)

Do we need to observe this version value in the manifest? Is it useful? Do we need to parse differently for different versions?

@asgrim asgrim added the question Further information is requested label Aug 21, 2019
@cschneid
Copy link
Contributor

  1. It is not useful right now, but is part of the json.
  2. It was being created incorrectly as part of the core agent release. Will be fixed today

The goal of it is to be a stable key with the "schema version" of the manifest.json file. An agent should be able to inspect it, and change behavior to support updating manifest structure (like hash format or whatever).

@dlanderson sound right?

@dlanderson
Copy link

Correct

@asgrim asgrim closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants