Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel/Lumen 9 and Symfony 6 support #256

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Feb 24, 2022

Fixes scoutapp/scout-apm-laravel#83

NOTE: there are BC breaks in this PR, as follows:

 - [BC] Scoutapm\Laravel\Providers\ScoutApmServiceProvider was marked "@internal"
 - [BC] Scoutapm\ScoutApmBundle\Twig\TwigDecorator was marked "@internal"
 - [BC] Scoutapm\ScoutApmBundle\ScoutApmBundle was marked "@internal"
 - [BC] Scoutapm\ScoutApmBundle\DependencyInjection\ScoutApmExtension was marked "@internal"
 - [BC] Symfony\Component\HttpKernel\Event\ControllerEvent was marked "@internal"
 - [BC] Scoutapm\Logger\FilteredLogLevelDecorator was marked "@internal"
 - [BC] The parameter $message of Psr\Log\LoggerTrait#emergency() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#alert() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#critical() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#error() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#warning() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#notice() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#info() changed from no type to a non-contravariant string|Stringable
 - [BC] The parameter $message of Psr\Log\LoggerTrait#debug() changed from no type to a non-contravariant string|Stringable
 - [BC] Symfony\Component\HttpKernel\Event\ControllerEvent was marked "@internal"

The Psr\Log-related BC breaks are because psr/log:^2.0 adds types. If consumers are still using psr/log:^1.0 this will be irrelevant.

@asgrim asgrim added the enhancement New feature or request label Feb 24, 2022
@asgrim asgrim self-assigned this Feb 24, 2022
composer.json Outdated Show resolved Hide resolved
@asgrim asgrim force-pushed the add-laravel-9-support branch 4 times, most recently from a5f16d2 to 6b27d63 Compare March 2, 2022 10:06
@asgrim asgrim added the BC BREAK This PR contains a BC break; major version should be incremented label Mar 2, 2022
composer.json Outdated Show resolved Hide resolved
@asgrim asgrim force-pushed the add-laravel-9-support branch 2 times, most recently from 02c85b1 to d5de513 Compare March 2, 2022 11:20
@asgrim asgrim marked this pull request as ready for review March 2, 2022 13:05
@asgrim asgrim force-pushed the add-laravel-9-support branch from 25e2115 to 6a184e0 Compare March 2, 2022 13:08
@asgrim asgrim force-pushed the add-laravel-9-support branch from 6a184e0 to 13afe48 Compare March 8, 2022 12:39
@asgrim asgrim added this to the 8.0.0 milestone Mar 8, 2022
@asgrim asgrim merged commit 43ee301 into master Mar 8, 2022
@asgrim asgrim deleted the add-laravel-9-support branch April 15, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to support new Laravel Version 9
1 participant