Skip to content

Commit

Permalink
Set the github base_ref as the --from for Roave/BackwardCompatibility…
Browse files Browse the repository at this point in the history
…Check
  • Loading branch information
asgrim committed Mar 8, 2022
1 parent 2e8cd6d commit 13afe48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
- name: "Composer update with new requirements"
run: "composer update --no-interaction --prefer-dist --prefer-stable"
- name: "Check for BC breaks"
run: ".github/workflows/roave-backwards-compatibility-check.sh"
run: ".github/workflows/roave-backwards-compatibility-check.sh --install-development-dependencies --from=origin/${{ github.base_ref }}"

###############################################################################
################################### SYMFONY ###################################
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/roave-backwards-compatibility-check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ cd "$(dirname "$0")/../.." || exit 2
echo "Running BC check, please wait..."

# Capture output to variable AND print it
OUTPUT=$(vendor/bin/roave-backward-compatibility-check --format=markdown --install-development-dependencies 2>&1)
OUTPUT=$(vendor/bin/roave-backward-compatibility-check --format=markdown "$@" 2>&1)

# Remove rows we want to suppress
OUTPUT=`echo "$OUTPUT" | sed '/Roave\\\BetterReflection\\\Reflection\\\ReflectionClass "Symfony\\\Component\\\HttpKernel\\\Event\\\FilterControllerEvent" could not be found in the located source/'d`
Expand Down

0 comments on commit 13afe48

Please sign in to comment.