Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of spans recorded to 1,500 #187

Merged
merged 9 commits into from
Sep 9, 2020
Merged

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Sep 3, 2020

Fixes #186
Fixes #51

@asgrim asgrim added the enhancement New feature or request label Sep 3, 2020
@asgrim asgrim added this to the 4.5.0 milestone Sep 3, 2020
@asgrim asgrim requested a review from cschneid September 3, 2020 15:57
asgrim added a commit that referenced this pull request Sep 7, 2020
@asgrim asgrim added the BC BREAK This PR contains a BC break; major version should be incremented label Sep 7, 2020
src/Agent.php Outdated Show resolved Hide resolved
@asgrim asgrim assigned asgrim and unassigned cschneid Sep 8, 2020
@asgrim asgrim added WIP Work in progress - do not merge and removed WIP Work in progress - do not merge labels Sep 8, 2020
@asgrim asgrim force-pushed the 186-limit-spans-recorded branch from 5410348 to 7e86d1c Compare September 9, 2020 08:23
@asgrim asgrim requested a review from cschneid September 9, 2020 08:38
@asgrim asgrim assigned cschneid and unassigned asgrim Sep 9, 2020
@asgrim asgrim merged commit 0d37606 into master Sep 9, 2020
@asgrim asgrim deleted the 186-limit-spans-recorded branch September 9, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a limit to number of spans collected Span is an "internal" API but is exposed when we start a span
2 participants