Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span is an "internal" API but is exposed when we start a span #51

Closed
asgrim opened this issue Sep 5, 2019 · 0 comments · Fixed by #187
Closed

Span is an "internal" API but is exposed when we start a span #51

asgrim opened this issue Sep 5, 2019 · 0 comments · Fixed by #187
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Sep 5, 2019

Not critical, but at the moment, the @internal class \Scoutapm\Events\Span\Span is exposed when $agent->startSpan is called, meaning the API isn't really internal.

One suggestion is to return a "public" version of a Span with the API promises, that proxies to the underlying real span class.
@asgrim asgrim added the enhancement New feature or request label Sep 5, 2019
asgrim added a commit that referenced this issue Sep 5, 2019
@asgrim
Removed todo identified as issue #51 created to handle
38e06c5
@asgrim asgrim added the nice to have This is a "nice to have" feature - not a critical requirement label Sep 13, 2019
@asgrim asgrim mentioned this issue Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit the number of spans recorded to 1,500 scoutapp/scout-apm-php
1 participant
@asgrim