Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to API and logging/debugging #117

Merged
merged 8 commits into from
Dec 3, 2019
Merged

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Nov 26, 2019

  • Hardens Agent API to require Logger in ::fromConfig()
  • Removes deprecated API (Agent::fromDefaults())
  • Makes Agent::__construct into a private method (forces using ::fromConfig())
  • Return the data that was read from the socket in Connector (for logging, primarily)
  • Adds a bunch of extra logging everywhere
  • Adds docs on how to turn off all the logging

@asgrim asgrim added the enhancement New feature or request label Nov 26, 2019
@asgrim asgrim added this to the 1.next milestone Nov 26, 2019
@asgrim asgrim requested a review from cschneid November 26, 2019 14:01
@asgrim asgrim added the BC BREAK This PR contains a BC break; major version should be incremented label Nov 26, 2019
@asgrim
Copy link
Collaborator Author

asgrim commented Nov 26, 2019

Note this PR breaks BC in several ways (noted in the changelog) which means, if merged, the next version will be 2.0.0, assuming we are following semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants