Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default logging implementation #125

Open
asgrim opened this issue Dec 3, 2019 · 2 comments
Open

Provide a default logging implementation #125

asgrim opened this issue Dec 3, 2019 · 2 comments
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Dec 3, 2019

#117 changes requirement to require a \Psr\Log\LoggerInterface explicitly into the agent, but the suggestion for a default is NullLogger.

We could provide a very basic logger implementation that writes to file for those who are not familiar with PSR-3 and suggest that as a default.

@asgrim asgrim added enhancement New feature or request question Further information is requested labels Dec 3, 2019
@asgrim
Copy link
Collaborator Author

asgrim commented Dec 3, 2019

Thoughts welcome on this...

@asgrim
Copy link
Collaborator Author

asgrim commented Dec 4, 2019

@cschneid said:

we do exactly that in ruby, although ruby provides 99% of the impl
python we rely on the native logger
ruby agent by default looks for a APP_ROOT/log/scout_apm.log file to write to
a log in /tmp with the app name would work

@asgrim asgrim removed the question Further information is requested label Dec 4, 2019
@asgrim asgrim added the nice to have This is a "nice to have" feature - not a critical requirement label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Development

No branches or pull requests

2 participants