Skip to content

Commit

Permalink
Merge pull request #110 from scoutapp/add-language-version-key
Browse files Browse the repository at this point in the history
Added language_version key to be sent with metadata
  • Loading branch information
Chris Schneider authored Nov 12, 2019
2 parents 0550fef + 733bd6c commit 8eec0cb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Changed

- Added `language_version` key to be sent with metadata (#110)
- Added more debug logging to isolate issues easier (#111)

## [1.0.0] 2019-11-05
Expand Down
1 change: 1 addition & 0 deletions src/Events/Metadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ private function data() : array
return [
'language' => 'php',
'version' => PHP_VERSION,
'language_version' => PHP_VERSION,
'server_time' => $this->timer->getStart(),
'framework' => 'laravel',
'framework_version' => '',
Expand Down
2 changes: 2 additions & 0 deletions tests/Unit/Events/MetadataTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public function testMetadataFromConfigurationSerializesToJson() : void
'event_value' => [
'language' => 'php',
'version' => PHP_VERSION,
'language_version' => PHP_VERSION,
'server_time' => $time->format(Timer::FORMAT_FOR_CORE_AGENT),
'framework' => 'laravel',
'framework_version' => '',
Expand Down Expand Up @@ -91,6 +92,7 @@ public function testAutoDetectedMetadataSerializesToJson() : void
'event_value' => [
'language' => 'php',
'version' => PHP_VERSION,
'language_version' => PHP_VERSION,
'server_time' => $time->format(Timer::FORMAT_FOR_CORE_AGENT),
'framework' => 'laravel',
'framework_version' => '',
Expand Down

0 comments on commit 8eec0cb

Please sign in to comment.