Merge pull request #111 from scoutapp/log-configuration-details-on-st…

…artup

Added additional debug logging to show connectivity details

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Changed
 
+ - Added more debug logging to isolate issues easier (#111)
+
 ## [1.0.0] 2019-11-05
 
 ### Changed

src/Agent.php

@@ -130,8 +130,17 @@ public static function fromConfig(Config $config, ?LoggerInterface $logger = nul
 
     public function connect() : void
     {
-        if (! $this->connector->connected() && $this->enabled()) {
-            $this->logger->info('Scout Core Agent Connection Failed, attempting to start');
+        if (! $this->enabled()) {
+            $this->logger->debug('Connection skipped, since monitoring is disabled');
+
+            return;
+        }
+
+        if (! $this->connector->connected()) {
+            $this->logger->info(sprintf(
+                'Scout Core Agent (app=%s) not connected yet, attempting to start',
+                $this->config->get(ConfigKey::APPLICATION_NAME)
+            ));
             $manager = new AutomaticDownloadAndLaunchManager(
                 $this->config,
                 $this->logger,
@@ -157,7 +166,10 @@ public function connect() : void
                 $this->logger->warning($failedToConnect->getMessage());
             }
         } else {
-            $this->logger->debug('Scout Core Agent Connected');
+            $this->logger->debug(sprintf(
+                'Scout Core Agent Connected (app=%s)',
+                $this->config->get(ConfigKey::APPLICATION_NAME)
+            ));
         }
     }
 

tests/Unit/AgentTest.php

@@ -119,7 +119,7 @@ public function testLogMessagesAreLoggedWhenUsingDefaultConfiguration() : void
             ->method('log')
             ->with(
                 LogLevel::DEBUG,
-                self::stringContains('Scout Core Agent Connected'),
+                self::stringContains('Connection skipped, since monitoring is disabled'),
                 []
             );