Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated score schema and types, added compatibility transformer #26

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

astromechza
Copy link
Member

@astromechza astromechza commented Feb 23, 2024

Score specification updates:

515c899 fix: make httpGet probe port required, fix volume read_only to be camelCase (#13)
2fb2c34 feat: added field restrictions and tests to the repository (#12)

This carries the following "breaking" changes:

  1. Removed multiline file content string
  2. Renamed volume read_only field to readOnly

To mitigate any impact on customers in the short term, there is a new function ApplyCommonUpgradeTransforms which can automatically apply these transforms to a spec before validation and transformation. This can then be used to train or adapt customers to use the new types, and this functionality can be disabled or skipped on a customer-by-customer basis if required.

Any other restrictions are formalizations of existing documented limitations or are otherwise enforced when deployed to docker, kubernetes, or humanitec.

Once merged, this will be brought into score-compose.

515c899 fix: make httpGet probe port required, fix volume read_only to be camelCase (#13)
2fb2c34 feat: added field restrictions and tests to the repository (#12)
1883aea fix: removed fully deprecated and unsupported resource properties field (#11)
cff7163 fix: made port required and targetport optional in serviceport definition (#10)
3910c0a fix: added missing protocol field in service ports (#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3)
6586e0e feat: support class in resources (#2)
REVERT: 7f3f6f3 feat: support class in resources

git-subtree-dir: schema/files
git-subtree-split: 515c89903bd1460a9b3e0ff7fb0b77d3cbd29cac

Signed-off-by: Ben Meier <[email protected]>
Copy link
Contributor

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@astromechza astromechza merged commit 2b44195 into main Feb 26, 2024
2 checks passed
@astromechza astromechza deleted the update-spec branch February 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants