-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for resource annotations and inputs hints #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Yarshevich <[email protected]>
Signed-off-by: Eugene Yarshevich <[email protected]>
Signed-off-by: Eugene Yarshevich <[email protected]>
This was
linked to
issues
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chrishumanitec
approved these changes
Apr 17, 2023
astromechza
added a commit
to astromechza/score-go
that referenced
this pull request
Jan 25, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (score-spec#11) cff7163 fix: made port required and targetport optional in serviceport definition (score-spec#10) 3910c0a fix: added missing protocol field in service ports (score-spec#8) d5df881 fix: converts anonmyous un-named structs into top-level defs (score-spec#5) bcd5a7f fix(schema): move unanchored refs to top level $defs c83d713 fix(schema): fixed additional properties with invalid regex patterns (score-spec#3) 6586e0e feat: support class in resources (score-spec#2) REVERT: 7f3f6f3 feat: support class in resources git-subtree-dir: schema/files git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza
added a commit
that referenced
this pull request
Feb 9, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (#11) cff7163 fix: made port required and targetport optional in serviceport definition (#10) 3910c0a fix: added missing protocol field in service ports (#8) d5df881 fix: converts anonmyous un-named structs into top-level defs (#5) bcd5a7f fix(schema): move unanchored refs to top level $defs c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3) 6586e0e feat: support class in resources (#2) REVERT: 7f3f6f3 feat: support class in resources git-subtree-dir: schema/files git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza
added a commit
that referenced
this pull request
Feb 9, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (#11) cff7163 fix: made port required and targetport optional in serviceport definition (#10) 3910c0a fix: added missing protocol field in service ports (#8) d5df881 fix: converts anonmyous un-named structs into top-level defs (#5) bcd5a7f fix(schema): move unanchored refs to top level $defs c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3) 6586e0e feat: support class in resources (#2) REVERT: 7f3f6f3 feat: support class in resources git-subtree-dir: schema/files git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza
added a commit
that referenced
this pull request
Feb 23, 2024
515c899 fix: make httpGet probe port required, fix volume read_only to be camelCase (#13) 2fb2c34 feat: added field restrictions and tests to the repository (#12) 1883aea fix: removed fully deprecated and unsupported resource properties field (#11) cff7163 fix: made port required and targetport optional in serviceport definition (#10) 3910c0a fix: added missing protocol field in service ports (#8) d5df881 fix: converts anonmyous un-named structs into top-level defs (#5) bcd5a7f fix(schema): move unanchored refs to top level $defs c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3) 6586e0e feat: support class in resources (#2) REVERT: 7f3f6f3 feat: support class in resources git-subtree-dir: schema/files git-subtree-split: 515c89903bd1460a9b3e0ff7fb0b77d3cbd29cac Signed-off-by: Ben Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for resource annotations (see #56) and resource inputs hints (see #9).
Types of changes
Checklist: