Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resource annotations and inputs hints #10

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

ghen
Copy link
Contributor

@ghen ghen commented Apr 17, 2023

Adds support for resource annotations (see #56) and resource inputs hints (see #9).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

ghen added 2 commits April 17, 2023 17:35
Signed-off-by: Eugene Yarshevich <[email protected]>
@ghen ghen force-pushed the feature/metadata branch from 40bc720 to 26ad56a Compare April 17, 2023 14:35
@ghen ghen marked this pull request as ready for review April 17, 2023 14:36
Signed-off-by: Eugene Yarshevich <[email protected]>
Copy link
Contributor

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghen ghen merged commit c1bf3fb into main Apr 17, 2023
@ghen ghen deleted the feature/metadata branch April 18, 2023 11:37
astromechza added a commit to astromechza/score-go that referenced this pull request Jan 25, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (score-spec#11)
cff7163 fix: made port required and targetport optional in serviceport definition (score-spec#10)
3910c0a fix: added missing protocol field in service ports (score-spec#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (score-spec#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (score-spec#3)
6586e0e feat: support class in resources (score-spec#2)
REVERT: 7f3f6f3 feat: support class in resources

git-subtree-dir: schema/files
git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza added a commit that referenced this pull request Feb 9, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (#11)
cff7163 fix: made port required and targetport optional in serviceport definition (#10)
3910c0a fix: added missing protocol field in service ports (#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3)
6586e0e feat: support class in resources (#2)
REVERT: 7f3f6f3 feat: support class in resources

git-subtree-dir: schema/files
git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza added a commit that referenced this pull request Feb 9, 2024
1883aea fix: removed fully deprecated and unsupported resource properties field (#11)
cff7163 fix: made port required and targetport optional in serviceport definition (#10)
3910c0a fix: added missing protocol field in service ports (#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3)
6586e0e feat: support class in resources (#2)
REVERT: 7f3f6f3 feat: support class in resources

git-subtree-dir: schema/files
git-subtree-split: 1883aea5fb8bca39946ce24604970dc1c372b100
astromechza added a commit that referenced this pull request Feb 23, 2024
515c899 fix: make httpGet probe port required, fix volume read_only to be camelCase (#13)
2fb2c34 feat: added field restrictions and tests to the repository (#12)
1883aea fix: removed fully deprecated and unsupported resource properties field (#11)
cff7163 fix: made port required and targetport optional in serviceport definition (#10)
3910c0a fix: added missing protocol field in service ports (#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3)
6586e0e feat: support class in resources (#2)
REVERT: 7f3f6f3 feat: support class in resources

git-subtree-dir: schema/files
git-subtree-split: 515c89903bd1460a9b3e0ff7fb0b77d3cbd29cac

Signed-off-by: Ben Meier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for resource annotations in the Score spec Add "resource inputs" as hints in Score
2 participants