-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split load of detector/monitor from event-data load #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
force-pushed
the
split-event-load
branch
from
August 7, 2024 03:30
eb0cd45
to
dc72e50
Compare
Workflow dependency restructure
I believe this was reviewed as part of #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is related to the new approach discussed in scipp/beamlime#215.
It depends on a release of scipp/essreduce#53, i.e., CI will fail for now.Edit:
converted to draft, since I found one more dependency on event data that should not be there (for solid angle).-> This is fixed by the follow-up #155 (now merged into this branch). -> Fixes #154.Also closes #39, closes #62.
By loading NXevent_data separately from the containing NXdetector or NXmonitor we increase flexibility, reduce overhead, and continue paving the path towards chunked processing of large files.
Before:
After:
Notes:
RawData[SampleRun]
, which is now the "empty" detector with no events, masks can be loaded and processed without loading potentially huge amounts of events. Even if the events will be loaded anyway this will improve parallelism, and will avoid reprocessing of masks if the event data changes.