You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we change this to return BeamCenter[RunType] and replace SampleRun -> RunType everywhere?
Points to consider:
We still want to be able to set the value of the beam center by hand. This would be more complicated if we had to do it for all possible run times. It would be easy to forget some of the run types, leading to inconsistent result.
We might want to reduce a run that has no sample run. Could be solved by setting beam center by hand.
The text was updated successfully, but these errors were encountered:
Does this mean that you would compute a beam center for SampleRun and BackgroundRun?
Could it be difficult to compute a reliable beam center on a background run if the signal is weak/noisy? I think typically the background run is recorded for less time than the sample run?
According to the scientists they would typically compute the beam center once, instead of doing it all the time. But maybe this is just because it used to be so slow using the old software?
Current implementation:
esssans/src/esssans/beam_center_finder.py
Lines 275 to 285 in 5c239c4
and
esssans/src/esssans/beam_center_finder.py
Lines 44 to 47 in 5c239c4
Should we change this to return
BeamCenter[RunType]
and replaceSampleRun
->RunType
everywhere?Points to consider:
The text was updated successfully, but these errors were encountered: