Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not depend on json template for mocking streaming. #242

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Do not depend on json template for mocking streaming. #242

merged 7 commits into from
Oct 18, 2024

Conversation

YooSunYoung
Copy link
Member

@YooSunYoung YooSunYoung commented Oct 4, 2024 •
edited
Loading

@SimonHeybrock

This update should allow you to run beamlime only with a file without any json structure.

beamlime \ 
    --nexus-file-path 60392-2022-02-28_2215.nxs \
    --workflow ess-loki-monitor \
    --log-level DEBUG \
    --merge-every-nth 20 \
    --image-path-prefix loki-test \
    --num-frames 40 \
    #--fill-dummy-data  # uncomment this if you want to use actual data from the file.

YooSunYoung
YooSunYoung commented Oct 4, 2024
View reviewed changes
src/beamlime/applications/handlers.py
@@ -105,7 +105,7 @@ def merge_data_piece(self, message: DataPieceReceived) -> DataReady | None:
self.debug("Data piece merged for %s", message.content.key)
if self._should_send_message():
nxevent_data = {
nexus_path_as_string(module_spec.path): JSONGroup(value)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug that I found as I tested it with a file : D....!! wheeee

@YooSunYoung
Copy link
Member Author

Feel free to make it better and proceed while I'm on vacation : D ...!

@YooSunYoung YooSunYoung marked this pull request as ready for review October 4, 2024 13:58
@YooSunYoung YooSunYoung mentioned this pull request Oct 4, 2024
Closed
@YooSunYoung
Copy link
Member Author

For testing, there are already existing tests that I had updated, but we still need to test fill-dummy-data.
I opened an issue #243 since it was too complicated to do it at once.

@YooSunYoung YooSunYoung mentioned this pull request Oct 4, 2024
Merged
SimonHeybrock
SimonHeybrock approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for testing with the new SANS workflows.

@YooSunYoung YooSunYoung merged commit 9f5f80d into main Oct 18, 2024
5 checks passed
@YooSunYoung YooSunYoung deleted the easy-mock-stream branch October 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonHeybrock SimonHeybrock SimonHeybrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YooSunYoung @SimonHeybrock