Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FakeListener for fill-dummy-data option #243

Closed
YooSunYoung opened this issue Oct 4, 2024 · 2 comments
Closed

Test FakeListener for fill-dummy-data option #243

YooSunYoung opened this issue Oct 4, 2024 · 2 comments

Comments

@YooSunYoung
Copy link
Member

Now we are updating the beamlime to use nexus file to use static information including FakeListener starting with #242 .

Existing tests already cover a lot of the updated parts but we still need to add tests for fill-dummy-data option if it is actually retrieving data from the file if asked.

The ymir_detectors.nxs file does not have any event data, so we may want to make a temporary file and add event data, and then see if the result is as expected.

@SimonHeybrock
Copy link
Member

It obviously works correctly, may not be worth adding a test that may require frequent refactoring.

@YooSunYoung YooSunYoung pinned this issue Oct 21, 2024
@YooSunYoung YooSunYoung unpinned this issue Oct 21, 2024
@YooSunYoung
Copy link
Member Author

Hmm yeah ... Maybe it's not so important since we already used it for manual testing a lot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants