-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to GitHub actions and readthedocs #108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 3 3
Lines 154 154
Branches 26 26
=======================================
Hits 149 149
Misses 4 4
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sauln I saw you've been pushing on this -- I have some comments that might be helpful. Also you might want to use pyproject.toml
for this repository since Cython is a requirement of setup.py
. You can see an example here for freud, which has similar requirements: https://github.com/glotzerlab/freud/blob/master/pyproject.toml
pyproject.toml
is discussed further here: https://www.python.org/dev/peps/pep-0518/
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
run: | | ||
python setup.py sdist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, I would try to release source distributions and wheel distributions at the same time. I think you could generate source dists and wheels on one platform (e.g. Linux) and then only upload wheels for Windows/other platforms. Here are some example scripts that might be useful.
https://github.com/glotzerlab/freud/blob/master/.circleci/deploy-linux.sh
https://github.com/glotzerlab/signac/blob/master/.circleci/deploy.bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like pypi doesn't support wheels for linux without using the manylinux
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are compatibility requirements to make things work on the majority of Linux distros. You can use one of the manylinux container images for deployment if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous versions didn't have linux wheels, so I'm fine passing on it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sauln Looks good to me!
Update custom domains to point to readthedocsthis will have to happen later and will not be part of the PR process@ctralie can you confirm the files uploaded to pypi (https://test.pypi.org/project/ripser/#files) are all the one's we need?