-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs build #253
Update docs build #253
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 80.32% 80.34% +0.02%
==========================================
Files 11 11
Lines 864 865 +1
Branches 189 203 +14
==========================================
+ Hits 694 695 +1
+ Misses 138 137 -1
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
scipy.sparse.random produces a random matrix with a deprecated matrix constructor. This instead uses a np.array style constructor.
I had to drop python 3.7 compatibility due to the way sparse matrices/arrays are handled in newer versions of scipy and numpy. Newer versions of numpy (and therefore scikit-learn) raise an error on sparse scipy matrices, in favor of sparse scipy arrays. These were not introduced until scipy 1.8.0, which requires python3.8+. This arose from me unpnning the dependencies and updating things. Rather than keeping the dependencies pinned, I'm in favor of dropping python3.7 support (its EoL anyways). I think unpinned dependencies is better moving forward so that we stay up to date with the packages we rely on. The built and published wheels can be used for backwards compatibility. |
This reverts commit ec4aaaa.
We're planning on making one larger release once several other PRs get merged in. I think this is good to go for now. |
@deargle @ctralie @sauln Please review this PR if you have any bandwidth to do so. Originally I intended this PR to be small to fix only the docs, but so much was deprecated that had to be updated. I fixed the github actions so the releases should work moving forward (there were several changes to master that were never released) along with updating the release process on PyPI, fixed the docs to use a modern readthedocs config, updated the runners to use current versions of python, and fixed some failing tests. |
The documentation and build process use outdated github actions. This PR updates these and adds a dependabot to ensure they remain up-to-date moving forward.
There were changes on master that never made it into a release because these procedures were out of date. Therefore, this PR may also fix some other lingering issues as well.