-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT update the python version supported #1073
Merged
glemaitre
merged 2 commits into
scikit-learn-contrib:master
from
glemaitre:update_dependencies
Mar 31, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,11 +3,23 @@ | |
| # Authors: Guillaume Lemaitre <[email protected]> | ||
| # License: MIT | ||
|
|
||
| import sys | ||
| import textwrap | ||
|
|
||
| import pytest | ||
|
|
||
| from imblearn.utils import Substitution | ||
| from imblearn.utils._docstring import _n_jobs_docstring, _random_state_docstring | ||
|
|
||
|
|
||
| def _dedent_docstring(docstring): | ||
| """Compatibility with Python 3.13+. | ||
|
|
||
| xref: https://github.com/python/cpython/issues/81283 | ||
| """ | ||
| return "\n".join([textwrap.dedent(line) for line in docstring.split("\n")]) | ||
|
|
||
|
|
||
| func_docstring = """A function. | ||
|
|
||
| Parameters | ||
|
|
@@ -55,6 +67,11 @@ def __init__(self, param_1, param_2): | |
| self.param_2 = param_2 | ||
|
|
||
|
|
||
| if sys.version_info.minor == "13": | ||
| func_docstring = _dedent_docstring(func_docstring) | ||
| cls_docstring = _dedent_docstring(cls_docstring) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "obj, obj_docstring", [(func, func_docstring), (cls, cls_docstring)] | ||
| ) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work. It returns
False. How aboutsys.version_info >= (3, 13)since it will be needed for future versions as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true that we need it for future python version. I falsely trust copilot without checking that it returns an integer (and we test for alpha python version). Thanks I'll make the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, if you want to stick with checking the minor version number only, compare to an integer, since that is what
sys.version_info.minorreturns. But that will only work until 3.14 is released.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Appreciated.
Btw, my last comment was not a response. I didn't get to see your comment to my first comment until I refreshed the page. 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I uploaded again the new wheels. Sorry for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries and thanks again for the quick fix.