MAINT update the python version supported #1073
Conversation
glemaitre
merged commit 5f98136
into
scikit-learn-contrib:master
| @@ -55,6 +67,11 @@ def __init__(self, param_1, param_2): | |||
| self.param_2 = param_2 | |||
|
|
|||
|
|
|||
| if sys.version_info.minor == "13": | |||
There was a problem hiding this comment.
That doesn't work. It returns False. How about sys.version_info >= (3, 13) since it will be needed for future versions as well?
There was a problem hiding this comment.
That's true that we need it for future python version. I falsely trust copilot without checking that it returns an integer (and we test for alpha python version). Thanks I'll make the fix.
There was a problem hiding this comment.
Or, if you want to stick with checking the minor version number only, compare to an integer, since that is what sys.version_info.minor returns. But that will only work until 3.14 is released.
There was a problem hiding this comment.
Thanks! Appreciated.
Btw, my last comment was not a response. I didn't get to see your comment to my first comment until I refreshed the page. 😞
There was a problem hiding this comment.
OK, I uploaded again the new wheels. Sorry for this.
There was a problem hiding this comment.
No worries and thanks again for the quick fix.
closes #1071
Update the supported python version and anticipate the release of Python 3.13.