-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Guard against nan in test stat calculation #1993
Conversation
@masonproffitt I'll bring this out of draft in the morning my time, but I'm about to go to bed. This needs:
|
Codecov ReportBase: 98.28% // Head: 98.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1993 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 68 68
Lines 4479 4479
Branches 730 730
=======================================
Hits 4402 4402
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This reverts commit 4145b4d.
c3c7056
to
9d6e7f9
Compare
Description
AsymptoticCalculator.teststatistic
issues warning and returnsnan
whenqmuA == 0
#1992Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: