Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable typehints in pre-commit and add typehints to readxml #1934

Merged
merged 27 commits into from
Aug 12, 2022
Merged

feat: Enable typehints in pre-commit and add typehints to readxml #1934

merged 27 commits into from
Aug 12, 2022

Commits on Aug 11, 2022

  1. add click infrastructure for handling the CLI option of volume mount

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    01be605 View commit details
    Browse the repository at this point in the history

  2. remove print

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e40e6f7 View commit details
    Browse the repository at this point in the history

  3. add functionality to handle mounts

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5958aa7 View commit details
    Browse the repository at this point in the history

  4. add types for resolver

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6cf3ad0 View commit details
    Browse the repository at this point in the history

  5. fix up typing for readxml

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5aae4c6 View commit details
    Browse the repository at this point in the history

  6. type the whole thing fully

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    592be6f View commit details
    Browse the repository at this point in the history

  7. fix up typehints

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bc82cf6 View commit details
    Browse the repository at this point in the history

  8. fix up typehints

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e069b86 View commit details
    Browse the repository at this point in the history

  9. fix up typehints

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c811d4c View commit details
    Browse the repository at this point in the history

  10. drop mocker

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    14d5c84 View commit details
    Browse the repository at this point in the history

  11. add test for runtime error addition

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2bef7b9 View commit details
    Browse the repository at this point in the history

  12. move to separate typing file

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b03095d View commit details
    Browse the repository at this point in the history

  13. initial setup so we can at least start checking that we type our code… 

    … correctly
    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    352af27 View commit details
    Browse the repository at this point in the history

  14. get typing working again

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cfde322 View commit details
    Browse the repository at this point in the history

  15. blah

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1d17037 View commit details
    Browse the repository at this point in the history

  16. fix up slightly

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    faf1aa8 View commit details
    Browse the repository at this point in the history

  17. stricten definitions a bit more

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    036b561 View commit details
    Browse the repository at this point in the history

  18. slightly more robust

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e5e5d1e View commit details
    Browse the repository at this point in the history

  19. typing_extensions added for 3.7

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3630599 View commit details
    Browse the repository at this point in the history

  20. literal fix

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bb74623 View commit details
    Browse the repository at this point in the history

  21. more cleanup

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    190cc56 View commit details
    Browse the repository at this point in the history

  22. TypedDict and Literal

    @kratsg
    kratsg committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    144444a View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Update .pre-commit-config.yaml 

    Co-authored-by: Matthew Feickert <[email protected]>
    @kratsg @matthewfeickert
    kratsg and matthewfeickert authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6d98aa3 View commit details
    Browse the repository at this point in the history

  2. Update src/pyhf/readxml.py 

    Co-authored-by: Matthew Feickert <[email protected]>
    @kratsg @matthewfeickert
    kratsg and matthewfeickert authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    53fa23a View commit details
    Browse the repository at this point in the history

  3. Update src/pyhf/readxml.py 

    Co-authored-by: Matthew Feickert <[email protected]>
    @kratsg @matthewfeickert
    kratsg and matthewfeickert authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    a3b83a4 View commit details
    Browse the repository at this point in the history

  4. Update src/pyhf/typing.py 

    Co-authored-by: Matthew Feickert <[email protected]>
    @kratsg @matthewfeickert
    kratsg and matthewfeickert authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    5ce97ea View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/readxmlTyping

    @kratsg
    kratsg authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    54b6426 View commit details
    Browse the repository at this point in the history