feat: Enable typehints in pre-commit and add typehints to readxml #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratsg
added
CI
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
+ Coverage 98.19% 98.22% +0.03%
==========================================
Files 68 69 +1
Lines 4365 4441 +76
Branches 734 749 +15
==========================================
+ Hits 4286 4362 +76
Misses 46 46
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kratsg
force-pushed
the
feat/readxmlTyping
branch
from
d65f7e9
to
190cc56
Compare
There was a problem hiding this comment.
Thanks for this nice work moving us towards typehints @kratsg! This looks good overall, I just have a few questions on pre-commit and then some suggestions (that can be ignored it you don't like them) that are simply reordering of imports to mitigate the amount of noise if we eventually turn on isort in pre-commit.
Co-authored-by: Matthew Feickert <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
matthewfeickert
approved these changes
Aug 12, 2022
4 tasks
This was referenced Aug 12, 2022
kratsg
pushed a commit
that referenced
this pull request
Aug 12, 2022
* Set the lower bound of the supported typing_extensions versions to v3.7.4 as TypedDict was added in v3.7.4. > The typing_extensions module contains both backports of these changes as > well as experimental types that will eventually be added to the typing module, > such as Protocol or TypedDict. - c.f. https://pypi.org/project/typing-extensions/3.7.4/ - Amends PR #1934 * Add typing-extensions==3.7.4 to tests/constraints.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will need to be rebased again on top of
masteronce #1909 is merged in.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: