Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: writexml handles missing parameter configs for normfactor #1819

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Mar 23, 2022

Pull Request Description

Fixes #1814.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* In situations in writexml where the normfactor parameter config is missing
inits or bounds, fall back to using default values instead.
* Add tests that use workspaces with no parameter inits and no parameter bounds
to cover this behavior.

@kratsg kratsg added the fix A bug fix label Mar 23, 2022
@kratsg kratsg self-assigned this Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1819 (34f37dd) into master (36e0d67) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          68       68           
  Lines        4310     4310           
  Branches      725      725           
=======================================
  Hits         4231     4231           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.42% <0.00%> (ø)
doctest 60.74% <0.00%> (ø)
unittests-3.10 96.03% <100.00%> (ø)
unittests-3.7 96.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/writexml.py 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e0d67...34f37dd. Read the comment docs.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @kratsg. LGTM.

@kratsg kratsg merged commit 6d03b9e into master Mar 23, 2022
@kratsg kratsg deleted the fix/json2xmlParInits branch March 23, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyhf json2xml requires parameter inits
2 participants