Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Require setuptools v42.0.0+ for stability #1783

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

matthewfeickert
Copy link
Member

Description

Resolves #1774

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* setuptools releases prior to v42.0.0 had stability issues with
pyproject.toml or didn't support PEP 517 and so couldn't support
pyproject.toml.
   - c.f. https://www.python.org/dev/peps/pep-0517/

Co-authored-by: Henry Schreiner <[email protected]>

matthewfeickert and others added 2 commits February 19, 2022 00:02
* setuptools releases prior to v42.0.0 had stability issues with
pyproject.toml or didn't support PEP 517 and so couldn't support
pyproject.toml.
   - c.f. https://www.python.org/dev/peps/pep-0517/

Co-authored-by: Henry Schreiner <[email protected]>
@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Feb 19, 2022
@matthewfeickert matthewfeickert self-assigned this Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #1783 (d6ecd26) into master (3691236) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1783   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3691236...d6ecd26. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 7428bed into master Feb 19, 2022
@matthewfeickert matthewfeickert deleted the build/require-setuptools-42 branch February 19, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Use `"setuptools>=42" in build-system requires in pyproject.toml
1 participant