Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use `"setuptools>=42" in build-system requires in pyproject.toml #1774

Closed
matthewfeickert opened this issue Feb 10, 2022 · 2 comments · Fixed by #1783
Closed

build: Use `"setuptools>=42" in build-system requires in pyproject.toml #1774

matthewfeickert opened this issue Feb 10, 2022 · 2 comments · Fixed by #1783
Labels
good first issue Good for newcomers

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 10, 2022

"setuptools>=30.3.0" should be "setuptools>=42"; anything before 42 was too buggy to be used with pyproject.toml (40-42), or didn't support pyproject.toml at all. (technically, PEP 517)

Originally posted by @henryiii in #1773 (comment)

So

pyhf/pyproject.toml

Lines 1 to 3 in b091985

[build-system]
# Minimum requirements for the build system to execute.
requires = ["wheel", "setuptools>=30.3.0", "attrs>=17.1", "setuptools_scm[toml]>=3.4"]

should be

requires = ["wheel", "setuptools>=42.0.0", "attrs>=17.1", "setuptools_scm[toml]>=3.4"]
@matthewfeickert matthewfeickert added the good first issue Good for newcomers label Feb 10, 2022
@RishiKumarRay
Copy link

RishiKumarRay commented Feb 10, 2022

@matthewfeickert i would like to take this, is this one available?

@RishiKumarRay
Copy link

@matthewfeickert is it available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants