-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for arrayful JSON #1647
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
=======================================
Coverage 98.03% 98.04%
=======================================
Files 63 63
Lines 4129 4145 +16
Branches 566 572 +6
=======================================
+ Hits 4048 4064 +16
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need tests?
bba85f5
to
87489b8
Compare
for more information, see https://pre-commit.ci
added! |
Should be good to go @kratsg @matthewfeickert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks!
cc @ponyisi as follow up to this Twitter thread. :) This will be in |
I think the CI is hanging because of Issue #1486 unfortunately. I'm happy to merge this in even with if "failing" as it was passing before (but I'm also a person who gets an irrational level of reassurance from seeing everything green so I'm happy to poke it a few more times). |
sample -> modifier sample_property -> sample
Oh, I think it is actually Issue #1451. Testing and if so then fixing it now. |
Thanks @lukasheinrich. 👍 |
Thanks for taking care of this! |
Description
this is a step towards #882 and allows tensor-like values in the spec
we relied a lot on
+=
being concatenatoin for python lists.. but now we first collect a list of lists/arrays and then dotb.concatenate
@phinate
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: