-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pyhf 0.7 compatibility #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1876 1876
Branches 298 298
=========================================
Hits 1876 1876
Continue to review full report at Codecov.
|
alexander-held
force-pushed
the
fix/pyhf-070
branch
from
November 15, 2021 15:00
e66c477
to
72b4014
Compare
1 task
alexander-held
force-pushed
the
fix/pyhf-070
branch
from
November 25, 2021 16:12
222c95d
to
6c13f1e
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
2 times, most recently
from
December 7, 2021 15:09
4aa9b95
to
a673d2f
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
3 times, most recently
from
February 3, 2022 19:22
e54495b
to
8e04e13
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
6 times, most recently
from
February 14, 2022 15:59
9174c15
to
26735d1
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
from
May 11, 2022 10:17
26735d1
to
03bd2e9
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
2 times, most recently
from
June 29, 2022 16:19
0a56a2b
to
3913dc3
Compare
alexander-held
force-pushed
the
fix/pyhf-070
branch
from
July 30, 2022 15:37
ae7cd74
to
e2b42a6
Compare
4 tasks
The last piece of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
cabinetry
to be compatible with the upcomingpyhf
version 0.7.0, and with the existing 0.7.0rc1.scikit-hep/pyhf#1625 changed the order of model parameters, so the tests are updated to work with the new parameter order.
scikit-hep/pyhf#1639 changed
paramset.suggested_fixed
, the previous functionality is now achieved viasuggested_fixed_as_bool
.CI temporarily failed due to changes in scikit-hep/pyhf#1639 that affect the
model.config.suggested_fixed
API return types, see scikit-hep/pyhf#1701 for details. Fixed via scikit-hep/pyhf#1706.Integration test tolerances are slightly relaxed due to small differences seen between different local setups (see also #318).
resolves #340 (nothing in particular needed in this PR to achieve that, but
pyhf
0.7 will resolve #340 so that problem will disappear withincabinetry
as well after this PR)resolves #344