Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix NumPy bound & noxfile installs #1913

Merged
merged 2 commits into from
Nov 25, 2022
Merged

chore: fix NumPy bound & noxfile installs #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a23cf7
chore: fix NumPy bound & noxfile installs
agoose77 Nov 24, 2022
049a758
Merge branch 'main' into agoose77/fix-pytest
agoose77 Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def tests(session):
"""
Run the unit and regular tests.
"""
session.install("-r", "requirements-test.txt", "./awkward-cpp", "./awkward")
session.install("-r", "requirements-test.txt", "./awkward-cpp", ".")
Copy link
Member

@henryiii henryiii Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in two lines, I think. Same below.

Suggested change
session.install("-r", "requirements-test.txt", "./awkward-cpp", ".")
session.install("-r", "requirements-test.txt", "./awkward-cpp")
session.install(".")

Also, I think if you reuse sessions it won't rebuild if the version doesn't change. I think.

session.run("pytest", *session.posargs if session.posargs else ["tests"])


Expand Down Expand Up @@ -51,7 +51,7 @@ def coverage(session):
"""
Run the unit and regular tests.
"""
session.install("-r", "requirements-test.txt", "./awkward-cpp", "./awkward")
session.install("-r", "requirements-test.txt", "./awkward-cpp", ".")
session.run(
"pytest", "tests", "--cov=awkward", "--cov-report=xml", *session.posargs
)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ classifiers = [
dependencies = [
"awkward_cpp==1",
"importlib_resources;python_version < \"3.9\"",
"numpy>=1.13.1",
"numpy>=1.14.5",
"packaging",
]
dynamic = [
Expand Down