chore: fix NumPy bound & noxfile installs #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Nov 24, 2022
| @@ -23,7 +23,7 @@ def tests(session): | |||
| """ | |||
| Run the unit and regular tests. | |||
| """ | |||
| session.install("-r", "requirements-test.txt", "./awkward-cpp", "./awkward") | |||
| session.install("-r", "requirements-test.txt", "./awkward-cpp", ".") | |||
There was a problem hiding this comment.
This needs to be in two lines, I think. Same below.
Suggested change
| session.install("-r", "requirements-test.txt", "./awkward-cpp", ".") | |
| session.install("-r", "requirements-test.txt", "./awkward-cpp") | |
| session.install(".") |
Also, I think if you reuse sessions it won't rebuild if the version doesn't change. I think.
ioanaif
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NumPy lower bound for Awkward increased when we moved to
python_version>=3.7. We made this fix in the CI, but not in the packaging metadata.We also didn't test the
testsorcoverageNox sessions, as they don't work withscikit-build-coreout of the box. I'll follow up with @henryiii, but in the mean time we can at least ensure that they try to install the right package 🤦📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-fix-pytest/ once Read the Docs has finished building 🔨