Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

362-requests-specs #380

Merged
merged 4 commits into from
Feb 15, 2024
Merged

362-requests-specs #380

merged 4 commits into from
Feb 15, 2024

Conversation

alishaevn
Copy link
Contributor

Story

stubbed requests cypress e2e tests are passing locally. they will still fail in ci due to configuration. (ref: #378)

Screenshots / Video

image

Testing

  1. pull this branch
  2. ensure you have all of the environment variables in the env property of "cypress.config.js" set up.
  3. run yarn cypress:e2e
  4. choose the "requests" test

@alishaevn alishaevn linked an issue Feb 13, 2024 that may be closed by this pull request
fix "requests" e2e specs #362
Closed
1 task
@alishaevn alishaevn marked this pull request as draft February 13, 2024 20:51
@alishaevn
Copy link
Contributor Author

alishaevn commented Feb 13, 2024 •
edited
Loading

converted to draft because this branch requires the code changes from #371 and #373 for the manual testing.

@alishaevn alishaevn marked this pull request as ready for review February 14, 2024 21:45
@summer-cook
Copy link
Contributor

Approved with the caveat that eslint should probably be fixed!

@alishaevn alishaevn merged commit 8f7e479 into main Feb 15, 2024
2 of 4 checks passed
@alishaevn alishaevn deleted the 362-requests-specs branch February 15, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summer-cook summer-cook summer-cook approved these changes

@labradford labradford Awaiting requested review from labradford

@aprilrieger aprilrieger Awaiting requested review from aprilrieger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix "requests" e2e specs
2 participants
@alishaevn @summer-cook