361 fix home specs #373
Merged
361 fix home specs #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`req.reply()` was not returning an empty response, it was returning the actual response from the server. this led to the "loading" state being present momentarily before the actual response was returned. we are now forcing the loading state to remain, as the mock intends.
made the cypress config file more dynamic. it also will allow us to correctly intercept api calls in our `customApiIntercept` command. update the "featured services list is loading" test check that we in fact have 3 placeholder items, as the description states.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
1 task
changed up the specs to fit the flow of the home page. also moving two specs from the browse page to the home page since that's where the requests originate from.
although we were catching the error in `#fetcher`, we weren't returning it as an error. it was being returned to the caller as the `data` value. this means none of our `isError` checks for GET requests were working properly. with this commit, we're throwing the error so that we are handling it on the view correctly.
we're testing for an invalid access token now. the `customApiIntercept` command is also simplified.
also further simplified the `customApiIntercept` function.
alishaevn
commented
Feb 13, 2024
| @@ -11,6 +11,7 @@ export const fetcher = (url, token) => { | |||
| .then(res => res.data) | |||
| .catch(error => { | |||
| Sentry.captureException(error) | |||
| throw error | |||
There was a problem hiding this comment.
without this, we are only getting the placeholder cards on the homepage, instead of the error notice.
if we use return instead of throw, then the useSWR hook would incorrectly get the error as the data property:
{
data: <AxiosError...>,
error: undefined
}
Merged
summer-cook
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
fix the 7 home specs locally. they will still fail in ci due to configuration. (ref: #378)
Screenshots / Video
Testing
envproperty of "cypress.config.js" set up.yarn cypress:e2e