Show PDF inputs fields appearing on work form

[ndroark]

Some fields (show pdf viewer, show pdf download button) are showing on work creation pages. It is unclear whether text entered in these fields affects the work display page, but the information is saved in these fields, and the presence of the fields will be confusing to users.

Testing Instructions

• EDIT a new work
• In the work's form, click additional fields. Search for "Show PDF" and verify there are no matches.
• There should be no input fields for show viewer or show pdf download button from this page.
• Click on the Files tab.
• if PDF.js is enabled (from the features settings of the admin dashboard), two checkboxes should appear to show viewer, and to show pdf download button.
• If the PDF.js is NOT enabled, these checkboxes will not be visible

[ShanaLMoore]

TODO: We need to figure out a way for get the yaml's form > display: false to actually hide the terms from the form. Right now it's getting ignored. If we completed remove the form block, then the backend won't have the term on the form and that causes other problems.

ref

• https://github.com/samvera/hyku/pull/2247/files#diff-1b3f35e56bbfdadb66d3544bf2237a1eea5b3f7c912db8658922f25de789e448R11

[jillpe]

SoftServ QA: ❌

PDF.js not enabled

Screen.Recording.2024-08-12.at.8.32.47.AM.mov

pdf.js enabled ❌
The checkboxes are not apearing under the files tab

Screen.Recording.2024-08-12.at.8.34.30.AM.mov

[kirkkwang]

Hey @jillpe, can you try this with a PDF file? It looks like you tried it with a JPEG which will not show in PDF.js because it's not a PDF.

[jillpe]

SoftServ QA Observations

UV Enabled

Screen.Recording.2024-08-14.at.12.52.34.PM.mov

PDF.js enabled

The checkboxes are not appearing

Screen.Recording.2024-08-14.at.12.54.06.PM.mov

[ShanaLMoore]

Looking into this. locally every work type is displaying the checkboxes when pdf.js is enabled.

The same work type on Staging is not displaying it. 🤔 Same sha: c663a10

[ShanaLMoore]

Troubleshooting Staging

show_for_pdf?(show_pdf_viewer) => *** NoMethodError Exception: undefined method `first' for true:TrueClass
nil

[ShanaLMoore]

VALKYRIE_TRANSITION wasn't set 🙃

When it is:

[laritakr]

QA RESULTS: PASS ✅

Fields do not show on Descriptions tab

Checkboxes show when PDF.js is enabled

Checkboxes do not show when PDF.js is disabled