Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦄 Hide PDF inputs from edit form #57

Closed
Tracked by #33
ShanaLMoore opened this issue Jun 3, 2024 · 5 comments
Closed
Tracked by #33

🦄 Hide PDF inputs from edit form #57

ShanaLMoore opened this issue Jun 3, 2024 · 5 comments
Labels
bug something isn't working High Priority

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 3, 2024

Verify that PDF.js is working on pals knapsack

UPDATE: Original title: PDF.js not functional

TODO:
PDF.js should be check boxes on the edit form's files tab only.
Hide the input field boxes from the description tab of the edit form.
PS. Marking the metadata yaml properties with form > display: false did not hide them.

@ShanaLMoore ShanaLMoore added High Priority bug something isn't working labels Jun 3, 2024
@ShanaLMoore ShanaLMoore self-assigned this Jun 3, 2024
@ShanaLMoore ShanaLMoore changed the title PDF.js is not functional 🦄 PDF.js is not functional Jun 3, 2024
@ShanaLMoore ShanaLMoore added the spike needs investigation and planning label Jun 3, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jun 3, 2024

Tested on STAGING

PS. The iiif print code to split PDFs has not been merged at this point.

Prerequisites:

  • set Features to PDF.js

Image

When PDF.js checkbox is off: ✅

  • it does not render PDF.js
![Image](https://github.com/scientist-softserv/palni_palci_knapsack/assets/10081604/de209fa2-318b-406c-a65b-35a78a6c81da)

Image

When PDF.js checkbox is on: ✅

  • it renders PDF.js
![Image](https://github.com/scientist-softserv/palni_palci_knapsack/assets/10081604/54ab8e35-eea5-4da4-b76e-54aec2d7a8fc)

Image

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jun 3, 2024

Show PDF options should NOT be on the form as inputs: ❌

  • it should render only as check boxes on the edit > files tab
  • it should not render input fields on the form ref

EDIT > FILES TAB ✅

Image

FORM ❌

Image

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jun 3, 2024

Locally, I do not see these check boxes in the files tab 🤔 but in pals staging I do.

UPDATE: RESOLVED. I didn't have my worker container running so it didn't know about the uploaded file.

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jun 3, 2024

Setting down due to a shift in priorities.

TODO: Hide the input fields from the description tab

@ShanaLMoore ShanaLMoore changed the title 🦄 PDF.js is not functional 🦄 Hide PDF inputs from edit form Jun 4, 2024
@ShanaLMoore ShanaLMoore removed the spike needs investigation and planning label Jun 7, 2024
@ShanaLMoore
Copy link
Contributor Author

dupe #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working High Priority
Projects
Status: Done
Development

No branches or pull requests

1 participant