408-three-fold-approach

[alishaevn]

Story

HYRAX_ANALYTICS=true is still set in the staging and prod environments so that the client doesn't miss any tracking. therefore, all the analytics partials still try to load. although the config got set initially, once we went through the hyku account settings, each config property was set to an empty string. so when the dashboard tried to load the user graph, the config was invalid.

we need for the app to still be able to read from the env variables, (old way) while also setting some defaults in the account settings. (new way) (e.g., adding fallbacks in #reload_analytics). the values won't show up in the ui though, so the client can still set them individually. the changes in this pr will be removed in #487 so that we are only using the "per tenant" approach.

as background: this change was also necessary because of the changes made to Hyrax::Analytics::Google#valid?. the method changes are better because we should be checking for the presence of values, not just keys. however, that's what caused us to need a fallback for our new settings fields.

Refs:

• Analytics - Collection Report shows deleted collections #408
• Analytics - Works report #409
• 408 analytics per tenant #479

Expected Behavior Before Changes

• the dashboard wouldn't load on staging because the analytics config was invalid

Expected Behavior After Changes

• leave the default analytics settings until the customer has updated the tenant settings in each environment