408 analytics per tenant #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
added a commit
that referenced
this pull request
May 17, 2023
we should instead be using the version of this file in hyrax at https://github.com/samvera/hyrax/blob/hyrax-v3.5.0/app/views/shared/_ga.html.erb co-authored-by: rob <[email protected]>
Merged
analytics will be programmatically determined by setting the appropriate values in the admin settings.
alishaevn
commented
May 17, 2023
…ithLocation rubocop setting for google.rb method
aprilrieger
reviewed
May 17, 2023
alishaevn
commented
May 18, 2023
Comment on lines
-53
to
-58
| GOOGLE_ANALYTICS_ID=see-1pass | ||
| GOOGLE_OAUTH_APP_NAME=palni-palci-demo | ||
| GOOGLE_OAUTH_APP_VERSION=1.0 | ||
| GOOGLE_OAUTH_PRIVATE_KEY_SECRET=notasecret | ||
| GOOGLE_OAUTH_PRIVATE_KEY_PATH=cred.p12 | ||
| GOOGLE_OAUTH_CLIENT_EMAIL=palni-palci-demo@palni-palci-demo.iam.gserviceaccount.com |
There was a problem hiding this comment.
analytics are determined on a per tenant basis, so these are no longer necessary.
alishaevn
commented
May 18, 2023
alishaevn
commented
May 18, 2023
alishaevn
force-pushed
the
408-analytics-per-tenant
branch
from
b03fe08
to
a887a57
Compare
orangewolf
requested changes
May 18, 2023
Co-authored-by: Rob Kaufman <[email protected]>
Co-authored-by: Rob Kaufman <[email protected]>
orangewolf
approved these changes
May 18, 2023
alishaevn
force-pushed
the
408-analytics-per-tenant
branch
from
3e55309
to
aef3953
Compare
This was referenced May 19, 2023
Merged
alishaevn
added a commit
that referenced
this pull request
Aug 1, 2023
we should instead be using the version of this file in hyrax at https://github.com/samvera/hyrax/blob/hyrax-v3.5.0/app/views/shared/_ga.html.erb Co-authored-by: rob <[email protected]>
16 tasks
kirkkwang
added a commit
that referenced
this pull request
Dec 8, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
kirkkwang
added a commit
that referenced
this pull request
Dec 8, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
Merged
kirkkwang
added a commit
that referenced
this pull request
Dec 11, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
kirkkwang
added a commit
that referenced
this pull request
Dec 11, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
kirkkwang
added a commit
that referenced
this pull request
Dec 11, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
kirkkwang
added a commit
that referenced
this pull request
Dec 11, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
kirkkwang
added a commit
that referenced
this pull request
Dec 11, 2023
This commit will revert the previous Google Analytics work and modify it to use the new Google Analytics 4 (GA4) tracking code. Ref: - #479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Expected Behavior Before Changes
.envor deploy.tmpl filesExpected Behavior After Changes
Screenshots / Video
analytics by default
analytics enabled