Combined Analysis View #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SemRelation and SynItem components
CarstenWickner
commented
Sep 26, 2017
| * impossible to split {@link Proposition} part after first of two items | ||
| */ | ||
| @Test | ||
| public void testSplitProposition_7() throws HmxException { |
There was a problem hiding this comment.
This tests the fix for an unrelated bug (#21) I found while testing the new features. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes included here are implementing the single/combined analysis view as described in issue #17 instead of the two completely separate analysis views.
The new combined view offers a few separate view toggles (via the "View" menu) to show/hide multiple parts of the analysis:
Additionally, the "Go to ... Analysis" buttons on the left/right have been removed and replaced by "View: Syntactical Analysis" and "View: Semantical Analysis" buttons in the tool bar at the top, which are only presets of the above view toggles matching the previous two views. A third "View: All Details" button enables all view toggles at once.
This implicitely also implements request #16 for being able to see both syntactical and semantical translations at once.
The SVG export was specifically excluded here, as that will be even harder to achieve (due to the numerous calculations made there).