Add meson.run command #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command operates in two modes. If a single argument is given, it uses subprocess's `shell=True`, so you can use shell substitution, as in: spin run 'echo $PYTHONPATH' If multiple arguments are given, it uses standard execution, e.g.: spin run python -c 'import sys; del sys.path[0]; import example_pkg' Enabling `shell=True` for the latter would incorrectly disregarded the quoting.
|
Thanks! Quick question, upon skimming the code, it's not clear to me when do you use single quotes vs no quotes? Is it worth documenting? |
I can make that more explicit, although this is standard shell behavior. If you don't use quotes, then your current shell will immediately expand variables like |
stefanv
force-pushed
the
run
branch
2 times, most recently
from
47c49c7 to
4d7ff76
Compare
|
I can't quite get Windows to do what I want, but I'm getting hold of a physical test machine soon which should help debugging significantly. |
jarrodmillman
approved these changes
Jul 1, 2023
|
Phew 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command operates in two modes. If a single argument is given, it uses subprocess's
shell=True, so you can use shell substitution, as in:spin run 'echo $PYTHONPATH'
If multiple arguments are given, it uses standard execution, e.g.:
spin run python -c 'import sys; del sys.path[0]; import example_pkg'
Enabling
shell=Truefor the latter would incorrectly disregarded the quoting.Closes #69