Make shell expansion more obvious

scientific-python · Mar 30, 2023 · 913ef41 · 913ef41
1 parent 1017da6
commit 913ef41
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -45,7 +45,7 @@ jobs:
         env:
           TERM: xterm-256color
         run: |
-          set -x
+          set -xe
           cd example_pkg
           spin build
           spin test
@@ -57,7 +57,7 @@ jobs:
         if: matrix.os == 'macos-latest'
         shell: bash
         run: |
-          set -x
+          set -xe
           cd example_pkg
           spin build
           spin test
@@ -67,12 +67,13 @@ jobs:
           spin run python -c 'import sys; del sys.path[0]; import example_pkg'
       - name: Functional tests (Windows)
         if: matrix.os == 'windows-latest'
+        shell: bash
         run: |
-          Set-PSDebug -Trace 1
+          set -xe
           cd example_pkg
           spin build
           spin test
           spin sdist
           spin example
-          spin run 'echo %PYTHONPATH%'
+          spin run 'echo $PYTHONPATH'
           spin run python -c 'import sys; del sys.path[0]; import example_pkg'
diff --git a/spin/cmds/meson.py b/spin/cmds/meson.py
@@ -254,12 +254,15 @@ def python(python_args):
 @click.command(context_settings={"ignore_unknown_options": True})
 @click.argument("args", nargs=-1)
 def run(args):
-    """🏁 Run a shell command with PYTHONPATH set.
+    """🏁 Run a shell command with PYTHONPATH set
 
     \b
     spin run make
     spin run 'echo $PYTHONPATH'
     spin run python -c 'import sys; del sys.path[0]; import mypkg'
+
+    If you'd like to expand a shell variable, like `$PYTHONPATH` in the example
+    above, you need to provide a single, quoted command to `run`.
     """
     if not len(args) > 0:
         raise RuntimeError("No command given")