Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add gcov flag when it's specified #183

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

vxst
Copy link
Contributor

@vxst vxst commented May 6, 2024

Solve problems running in environments without gcov.

Fix numpy tests on x86-64, LP64 OpenBLAS (MSVC) and x86-64, LP64 OpenBLAS (Clang-cl)

Run spin test
  spin test
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    pythonLocation: C:\hostedtoolcache\windows\Python\3.11.9\x64
    PKG_CONFIG_PATH: D:\a\numpy\numpy/.openblas
    Python_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.11.9\x64
    Python2_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.11.9\x64
    Python3_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.11.9\x64
Invoking `build` prior to running tests:
Error: build() got an unexpected keyword argument 'gcov'; aborting.
Error: Process completed with exit code 1.

Solve problems running in environment not having gcov
@ngoldbaum
Copy link
Contributor

I'm also seeing this on my mac dev environment running spin test on the numpy repo.

@stefanv stefanv added the type: Bug fix Something isn't working label May 6, 2024
@stefanv
Copy link
Member

stefanv commented May 6, 2024

Thanks for the fix @vxst!

@stefanv
Copy link
Member

stefanv commented May 6, 2024

I'm going to merge this one, but it'd be good to have a test as well: #184

@stefanv stefanv merged commit 0157ef5 into scientific-python:main May 6, 2024
17 of 18 checks passed
@jarrodmillman jarrodmillman added this to the 0.10 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants