Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #183 #184

Closed
stefanv opened this issue May 6, 2024 · 4 comments
Closed

Add test for #183 #184

stefanv opened this issue May 6, 2024 · 4 comments

Comments

@stefanv
Copy link
Member

stefanv commented May 6, 2024

Failure without gcov

@vxst
Copy link
Contributor

vxst commented May 6, 2024

Shall I inject ctx.invoke? What's your recommendation on testing not passing gcov to build_cmd?

@stefanv
Copy link
Member Author

stefanv commented May 6, 2024

Ah, right, this is because NumPy's custom build command doesn't have the same signature as the built-in build command. That's probably something that has to be addressed on the NumPy side, so it's OK to leave it "untested". We should have some freedom to change internal command APIs across versions.

@stefanv stefanv closed this as completed May 6, 2024
@vxst
Copy link
Contributor

vxst commented May 6, 2024

Relying on strange things happens on a big project. I'll see whether it's possible to fix it on numpy side when I got time. :-)

@stefanv
Copy link
Member Author

stefanv commented May 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants