(DO NOT MERGE) Solr wrapper test fix #1153
Conversation
eddierubeiz
force-pushed
the
solr_wrapper_test_fix
branch
from
93f5838
to
8f40dc4
Compare
config/solr_wrapper_test.yml
Outdated
| @@ -11,6 +11,7 @@ collection: | |||
| dir: solr/config | |||
| name: hydra-test | |||
| version: 6.3.0 | |||
| # validate: false # until solr_wrapper stops hardwiring the checksum URL | |||
There was a problem hiding this comment.
this is commented out, you still want to put it in there commented out?
There was a problem hiding this comment.
It should be commented out, yes, but the comment is misleading. Let me amend the commit using my new git --amend superpowers.
There was a problem hiding this comment.
Updated and off to lunch. BRB
|
Another alternative is simply removing our If we remove the mirror_url, we could spend more time trying to get cbeer to merge/release the fix in solr_wrapper, or convincing others that we should fork it so someone else can. |
…ache.org to include in what will be committed
eddierubeiz
force-pushed
the
solr_wrapper_test_fix
branch
from
8f40dc4
to
10477fc
Compare
|
I guess we'll do this for now, although honestly it kind of terrifies me. |
|
The best alternative would be for the already-existing patches in solr_wrapper to be merged/released. I filed a ticket on solr_wrapper asking if cbeer would consider adding additional committers. cbeer/solr_wrapper#122 |
eddierubeiz
changed the title
Monkey patch to incorporate cbeer/solr_wrapper@eaab9cd into our code until/unless solr_wrapper incorporates it.
(We can also simply not use the Princeton mirror for a bit, or just set validate: false in the SOLR yaml ).